TST: Fixed version comparison #20469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This failed to skip for 3.5.x because the micro component made it False.
TomAugspurger
added
Testing
jorisvandenbossche
approved these changes
Mar 23, 2018
jreback
reviewed
Mar 23, 2018
| @@ -81,7 +81,7 @@ def test_fillna_frame(self): | |||
|
|
|||
| class TestMethods(base.BaseMethodsTests): | |||
| unhashable = pytest.mark.skip(reason="Unhashable") | |||
| unstable = pytest.mark.skipif(sys.version_info <= (3, 5), | |||
| unstable = pytest.mark.skipif(sys.version_info < (3, 6), | |||
There was a problem hiding this comment.
Ah, it's not obvious that compat.PY36 is 36 or greater. I thought it was exactly 3.6
Codecov Report
@@ Coverage Diff @@
## master #20469 +/- ##
==========================================
+ Coverage 91.83% 91.84% +<.01%
==========================================
Files 152 152
Lines 49231 49231
==========================================
+ Hits 45213 45215 +2
+ Misses 4018 4016 -2
Continue to review full report at Codecov.
|
jschendel
reviewed
Mar 23, 2018
| @@ -4,6 +4,7 @@ | |||
| import pytest | |||
|
|
|||
|
|
|||
| from pandas.compat import PY36 | |||
There was a problem hiding this comment.
I think you can also import PY2 here and replace sys.version_info[0] == 2 on line 12 with it, as that is the exact definition of PY2. That's the only remaining reference to sys, so you could then remove the import sys too.
javadnoorb
pushed a commit
to javadnoorb/pandas
that referenced
this pull request
Mar 29, 2018
* TST: Fixed version comparison This failed to skip for 3.5.x because the micro component made it False. * Use pandas.compat * More pandas compat
dworvos
pushed a commit
to dworvos/pandas
that referenced
this pull request
Apr 2, 2018
* TST: Fixed version comparison This failed to skip for 3.5.x because the micro component made it False. * Use pandas.compat * More pandas compat
kornilova203
pushed a commit
to kornilova203/pandas
that referenced
this pull request
Apr 23, 2018
* TST: Fixed version comparison This failed to skip for 3.5.x because the micro component made it False. * Use pandas.compat * More pandas compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This failed to skip for 3.5.x because the micro component made it False.
closes #20468